-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-102541: Fix Helper.help("mod") for non-existent mod #105934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @corona10 |
I am out of OSS for this month. If this PR is urgent, I would like to request reviewing of this PR to other reviewers. |
sobolevn
reviewed
Jun 20, 2023
terryjreedy
changed the title
gh-102541: Fix Helper.help when output is non default
gh-102541: Fix Helper.help("mod") for non-existent mod
Jul 1, 2023
terryjreedy
reviewed
Jul 1, 2023
terryjreedy
added
needs backport to 3.11
only security fixes
needs backport to 3.12
bug and security fixes
labels
Jul 1, 2023
Thanks @Eclips4 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 1, 2023
…H-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
GH-106322 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 1, 2023
…H-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
GH-106323 is a backport of this pull request to the 3.11 branch. |
terryjreedy
added a commit
that referenced
this pull request
Jul 1, 2023
) (#106323) gh-102541: Fix Helper.help("mod") for non-existent mod (GH-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy
added a commit
that referenced
this pull request
Jul 1, 2023
) (#106322) gh-102541: Fix Helper.help("mod") for non-existent mod (GH-105934) If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None. --------- (cherry picked from commit 0530f4f) Co-authored-by: Kirill Podoprigora <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
output
arg toHelper()
is a stream rather than the default None, which means 'page to stdout', the ImportError frompydoc.resolve
is currently not caught in `pydoc.doc. The same error is caught when output is None.Traceback:
EDITED by terryjreedy July 1, 2023 to better describe the issue, so I could review the patch,
and show the current result after the merge of the first PR for the issue. Instead of the last line
there were about 15 lines that repeated the Traceback.
help
CLI shows a traceback when import failed #102541