Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-68654: Clarify subdirectories used by pkgutil.extend_path #103701

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

san-juan1667
Copy link
Contributor

@san-juan1667 san-juan1667 commented Apr 22, 2023

Clarified sub directories used by pkgutil extend_path in docs and doc string

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 22, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@san-juan1667 san-juan1667 force-pushed the gh-686545-clarify-extend_path branch from 360260a to ec040e2 Compare April 22, 2023 23:04
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@CAM-Gerlach CAM-Gerlach added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes labels Apr 22, 2023
@san-juan1667 san-juan1667 changed the title gh-686545: Clarify sub directories used by pkgutil extend_path gh-68654: Clarify sub directories used by pkgutil extend_path Apr 22, 2023
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @san-juan1667 ! Congratulations on your first PR to CPython (and maybe my first ever commit)!

@CAM-Gerlach CAM-Gerlach changed the title gh-68654: Clarify sub directories used by pkgutil extend_path gh-68654: Clarify subdirectories used by pkgutil.extend_path Apr 22, 2023
@CAM-Gerlach CAM-Gerlach merged commit 7bf9456 into python:main Apr 22, 2023
@miss-islington
Copy link
Contributor

Thanks @san-juan1667 for the PR, and @CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2023
…ythonGH-103701)

Clarify sub directories used by pkgutil.extend_path in the docs and the docstring
(cherry picked from commit 7bf9456)

Co-authored-by: Randy <[email protected]>
@bedevere-bot
Copy link

GH-103702 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 22, 2023
@python python deleted a comment from bedevere-bot Apr 23, 2023
@terryjreedy
Copy link
Member

Line 85 Warning: ModuleSpec is a class in importlib.machinery. Add 'importlib.machinery' to get rid of the warning. An easy fix if still sprinting tomorrow.

CAM-Gerlach pushed a commit that referenced this pull request Apr 23, 2023
…H-103701)

gh-68654: Clarify subdirectories used by pkgutil.extend_path (GH-103701)

Clarify sub directories used by pkgutil.extend_path in the docs and the docstring
(cherry picked from commit 7bf9456)

Co-authored-by: Randy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants