gh-101659: initialize stack variable _sharedexception #103048
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
./Modules/_xxsubinterpretersmodule.c
a variable_sharedexception exc
on stack is declared introduced in #102659. The variable is not initialized.In
_run_script
, it's possible that the function hits an error and goes toerror
label without properly initializing the variable. Then_sharedexception_bind
can also potentially error out to trigger_sharedexception_clear(sharedexc)
, which may free the uninitialized pointer. I have not found an exploit on this, but there's a potential path. Also the fix is so easy and cheap so I think we can just initialize the variable withno_exception
(basically{0}
).Oh BTW, gcc complains with the possible unitialized variable.
I would guess @ericsnowcurrently is the right person to review this? Thanks!