Reorganize C API tests

[serhiy-storchaka]

BPO	34272
Nosy	@rhettinger, @ezio-melotti, @voidspace, @serhiy-storchaka, @miss-islington, @tirkarthi
PRs	bpo-34272: Reorganize C API tests. #8551 bpo-34272: Move argument parsing tests from test_capi to test_getargs2. #8567 [3.7] bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567) #8689 [3.6] bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567). #8690 [2.7] bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567). #8691 [3.6] bpo-34272: Restore test_capi.EmbeddingTests, unintentionally removed in 278d975c #10078

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2018-07-29.12:56:00.979>
labels = ['3.7', 'expert-C-API', '3.8', 'type-feature', 'tests']
title = 'Reorganize C API tests'
updated_at = <Date 2019-12-09.16:13:39.037>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2019-12-09.16:13:39.037>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests', 'C API']
creation = <Date 2018-07-29.12:56:00.979>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 34272
keywords = ['patch']
message_count = 8.0
messages = ['322635', '322648', '322656', '322682', '323207', '323209', '323210', '323211']
nosy_count = 6.0
nosy_names = ['rhettinger', 'ezio.melotti', 'michael.foord', 'serhiy.storchaka', 'miss-islington', 'xtreak']
pr_nums = ['8551', '8567', '8689', '8690', '8691', '10078']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34272'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

• PR: gh-78453: Move Unicode C API tests from test_unicode to test_capi.test_unicode #99431

• PR: [3.11] gh-78453: Move Unicode C API tests from test_unicode to test_capi.test_unicode (GH-99431). #99614

• PR: [3.10] gh-78453: Move Unicode C API tests from test_unicode to test_capi.test_unicode (GH-99431). #99617

[serhiy-storchaka]

The proposed PR reorganizes C API tests. Most C API tests will be moved into the new directory Lib/test/test_capi/.

[rhettinger]

It seems to me that this will make the individual objects and modules harder to maintain. I expect to find all the tests for an object in a file called test_thatobject.py. This patch violates that expectation and separates things that belong together.

[serhiy-storchaka]

Not all C API tests are related to specific type or module. What about moving just test_capi.py, test_getargs2.py and test_structmembers.py?

[serhiy-storchaka]

PR 8567 moves argument parsing tests from test_capi to test_getargs2.

It also makes tests defined in _testcapi more discoverable. Now you can run "./python -m test -v -m test_buildvalue_N test_capi".

[serhiy-storchaka]

New changeset 8f7bb10 by Serhiy Storchaka in branch 'master':
bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567)
8f7bb10

[miss-islington]

New changeset a1ff5f9 by Miss Islington (bot) in branch '3.7':
bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567)
a1ff5f9

[serhiy-storchaka]

New changeset 278d975 by Serhiy Storchaka in branch '3.6':
[3.6] bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567). (GH-8690)
278d975

[serhiy-storchaka]

New changeset d1c5e27 by Serhiy Storchaka in branch '2.7':
[2.7] bpo-34272: Move argument parsing tests from test_capi to test_getargs2. (GH-8567). (GH-8691)
d1c5e27

[iritkatriel]

Is there anything left to do here?

[encukou]

Plenty. test_capi/test_misc.py still has 1800+ lines.

[vstinner]

See also issue gh-93649.

[serhiy-storchaka]

The tests were re-organized, extended, updated and re-re-organized many times.