Remove #pragma that disables optimization on _PyEval_EvalFrameDefault on MSVC

[mdboom]

Feature or enhancement

Proposal:

The bug that caused a compiler crash has now been fixed upstream. We should remove our workaround to disable optimization on PGO builds on MSVC (and presumably get a modest speedup).

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

• gh-129244: Remove workaround for MSVC compiler crash #129263
• gh-129244: Only remove the workaround when MSVC has the bugfix #130011

[itamaro]

Looks like this is done, closing.

[ambv]

This will have to be reverted for now as the 3.14.0a5 build is failing.

[ambv]

See #130004.

[ambv]

As we are using the Azure Pipelines VMs to build, we are not controlling the version of the compiler and so far the version available on the image we're using (2025020.1.0 with Visual Studio 2022 17.12.12+1cce77968) there does not have the fix.

@mdboom do you know which VS version would be sufficient to reintroduce the change from this ticket?

[mdboom]

The minimum version of cl.exe required is 19.43.34618, which is currently in prerelease. I was under the (wrong) impression that this would be backported to the maintenance branch, which is why I submitted the PR. We can add a version check now so that when this does eventually make it into a primary release, we will be ready.

[Fidget-Spinner]

Marking as deferred blocker so we don't forget to fix this by 3.14 final.

[chris-eibl]

Upgrading to Visual Studio 2022 17.13.0 Preview 5.0, which ships with cl.exe 19.43.34808, works for me.
I had those issues on 17.12.4 and 17.12.3, too.

[encukou]

With #130011 merged, can this be closed?