Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the C API tests for Mapping Protocol and Sequence Protocol #107178

Closed
serhiy-storchaka opened this issue Jul 24, 2023 · 0 comments · Fixed by #107728
Closed

Add the C API tests for Mapping Protocol and Sequence Protocol #107178

serhiy-storchaka opened this issue Jul 24, 2023 · 0 comments · Fixed by #107728
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir topic-C-API

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jul 24, 2023 •
edited by bedevere-bot
Loading

Currently only few functions in these protocols are covered by tests: PyMapping_Keys, PyMapping_Values, PyMapping_Items, PyMapping_HasKey, PyMapping_HasKeyString, PySequence_SetSlice, PySequence_DelSlice. Since we just added few new functions (PyMapping_GetOptionalItem, etc) and are planning to deprecate other functions (PyMapping_HasKey, etc), we need more tests.

Linked PRs
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Jul 24, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jul 24, 2023
@serhiy-storchaka
pythongh-107178: Add the C API tests for the Abstract Objects Layer
d553110 
Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir topic-C-API 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes and removed type-feature A feature request or enhancement labels Jul 24, 2023
@bedevere-bot bedevere-bot mentioned this issue Jul 24, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Aug 7, 2023
@serhiy-storchaka
gh-107178: Add the C API tests for the Abstract Objects Layer (GH-107179
16c9415 
)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 7, 2023
@serhiy-storchaka
[3.12] pythongh-107178: Add the C API tests for the Abstract Objects …
6e9cbc9 
…Layer (pythonGH-107179)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API..
(cherry picked from commit 16c9415)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue Aug 7, 2023
Merged
@serhiy-storchaka serhiy-storchaka removed the 3.11 only security fixes label Aug 7, 2023
@serhiy-storchaka serhiy-storchaka linked a pull request Aug 16, 2023 that will close this issue
[3.12] gh-107178: Add the C API tests for the Abstract Objects Layer (GH-107179) #107728
Merged
Yhg1s pushed a commit that referenced this issue Aug 16, 2023
@serhiy-storchaka
[3.12] gh-107178: Add the C API tests for the Abstract Objects Layer (G…
9c8dfce 
…H-107179) (#107728)

Cover all the Mapping Protocol, almost all the Sequence Protocol
(except PySequence_Fast) and a part of the Object Protocol.

Move existing tests to Lib/test/test_capi/test_abstract.py and
Modules/_testcapi/abstract.c.

Add also tests for PyDict C API..
(cherry picked from commit 16c9415)
vstinner added a commit to vstinner/cpython that referenced this issue Aug 24, 2023
@vstinner
pythongh-107178: Remove _testcapi.test_dict_capi()
71b126d 
The new _testcapi.test_dict tests are more complete,
_testcapi.test_dict_capi() became redundant.
@bedevere-bot bedevere-bot mentioned this issue Aug 24, 2023
Merged
vstinner added a commit that referenced this issue Aug 24, 2023
@vstinner
gh-107178: Remove _testcapi.test_dict_capi() (#108436)
fa626b8 
The new _testcapi.test_dict tests are more complete,
_testcapi.test_dict_capi() became redundant.
@serhiy-storchaka serhiy-storchaka mentioned this issue Aug 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir topic-C-API
Projects
None yet
Milestone
No milestone
1 participant
@serhiy-storchaka