Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_paramspec_tvars in typing.py does nothing #104392

Closed
JelleZijlstra opened this issue May 11, 2023 · 0 comments
Closed

_paramspec_tvars in typing.py does nothing #104392

JelleZijlstra opened this issue May 11, 2023 · 0 comments
Labels
topic-typing type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 11, 2023 •
edited by bedevere-bot
Loading

Several classes in typing.py pass around an attribute called _paramspec_tvars, but nothing depends on its value. It was added in b2f3f8e by @Fidget-Spinner to enforce some behavior around ParamSpec, but since then we have apparently loosened that behavior. Let's just remove the attribute.

Linked PRs
@JelleZijlstra JelleZijlstra added type-bug An unexpected behavior, bug, or error topic-typing labels May 11, 2023
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 11, 2023
@JelleZijlstra
pythongh-104392: Remove _paramspec_tvars from typing
d023d87 
This does nothing.
@bedevere-bot bedevere-bot mentioned this issue May 11, 2023
Merged
JelleZijlstra added a commit that referenced this issue May 11, 2023
@JelleZijlstra
gh-104392: Remove _paramspec_tvars from typing (#104393)
37a5d25 
This does nothing.
carljm added a commit to carljm/cpython that referenced this issue May 12, 2023
@carljm
Merge branch 'main' into supermon
8efd7c6 
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-typing type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @AlexWaygood