Skip to content

Commit

Permalink
gh-92597: Improve error message for AST nodes with invalid ranges (GH…
Browse files Browse the repository at this point in the history
  • Loading branch information
pablogsal authored Jun 1, 2022
1 parent 8aa9d40 commit 8a221a8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Python/ast.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ static int validate_pattern(struct validator *, pattern_ty, int);
#define VALIDATE_POSITIONS(node) \
if (node->lineno > node->end_lineno) { \
PyErr_Format(PyExc_ValueError, \
"line %d-%d is not a valid range", \
"AST node line range (%d, %d) is not valid", \
node->lineno, node->end_lineno); \
return 0; \
} \
if ((node->lineno < 0 && node->end_lineno != node->lineno) || \
(node->col_offset < 0 && node->col_offset != node->end_col_offset)) { \
PyErr_Format(PyExc_ValueError, \
"line %d-%d, column %d-%d is not a valid range", \
node->lineno, node->end_lineno, node->col_offset, node->end_col_offset); \
"AST node column range (%d, %d) for line range (%d, %d) is not valid", \
node->col_offset, node->end_col_offset, node->lineno, node->end_lineno); \
return 0; \
} \
if (node->lineno == node->end_lineno && node->col_offset > node->end_col_offset) { \
Expand Down

0 comments on commit 8a221a8

Please sign in to comment.