Skip to content

cleanup: fix misc types in context, external_commands and finders #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

shubhbapna
Copy link
Collaborator

part of #226

fixes

src/fromager/external_commands.py:32: error: Function is missing a return type annotation  [no-untyped-def]
src/fromager/external_commands.py:32: note: Use "-> None" if function does not return a value
src/fromager/context.py:138: error: Function is missing a return type annotation  [no-untyped-def]
src/fromager/finders.py:24: error: Function is missing a return type annotation  [no-untyped-def]
src/fromager/__main__.py:25: error: Call to untyped function "detect_network_isolation" in typed context  [no-untyped-call]

@shubhbapna shubhbapna requested a review from tiran August 6, 2024 19:47
@mergify mergify bot merged commit fccb23a into python-wheel-build:main Aug 6, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants