Digest Authentification support for the legacy client part only

[Nicolas-Feude]

From the module "requests", but works on its own, totaly independent from it

[Nicolas-Feude]

Hello aaugustin!

First of all, sorry for not having done any actions on this PR, I've been really busy this last month...
I'd like to modify the quality tests, in order to make it ok with this new feature (digest authentification), but i don't know where to start, and what to change.
The current tests seems to handle only basic auth, which may explain why it fails with the digest auth.
Do you have any idea or suggestions about what i should do?

[Nicolas-Feude]

Hello
I don't know if the tests have been run after the commit 0851a24. The modification should have solved the error, but I don't have any results.
Could you run the tests if not already done?

[Nicolas-Feude]

Thanks

There is no more error message, but the coverage is not 100%. I obviously still have problems in this feature. I don't really know how to read the Tox report...
I can see that the issues are in headers.py (57%), legacy/client.py (89%) and legacy/handshake.py (95%) which are the files i modified for this PR... But i don't really understand what the "missing" column stand for, and what are the defaults/errors.

I'm sorry, I've never used Tox before, so I don't know what to do.

Is there a more detailled report ?

[Nicolas-Feude]

ok, i'm reading some documentation about tox and if i interpret correctly, the missing column is about the code that is not covered by the tests. So it means that i must write some tests to cover the new feature.

Sorry for the silly questions, i'm really newbie at tox/unit tests things

[Nicolas-Feude]

Is that possible to write digest auth coverage tests without having the server side modified to support digest auth ? I am not sure, but i guess that the server side digest auth is mandatory when the client side support the digest auth.

If i'm right the server must be modified to support digest auth. Am i correct ?

[ciacon]

I am seeing two different attempts of attempts of getting digest authentication into websockets - here and in #788 .
While I see some activity in both, I am not actually seeing any progress in either.

What is needed to get this ball rolling? :)

[aaugustin]

Hello, sorry this wasn't a priority for me back then; there was no discussion of the design before submitting the pull request; and as it stands it isn't on the right track. I'm going to close it for the reasons described in the related issue (for future reference).

[Nicolas-Feude]

Hello No problem for me, that was a quick and dirty hack for an old project i am not using and maintaining anymore :) Good luck and wonderful job for websockets ! Le 2 février 2025 09:39:41 GMT+01:00, Aymeric Augustin ***@***.***> a écrit :

…

Hello, sorry this wasn't a priority for me back then; there was no discussion of the design before submitting the pull request; and as it stands it isn't on the right track. I'm going to close it for [the reasons described in the related issue](#784 (comment)) (for future reference). -- Reply to this email directly or view it on GitHub: #1111 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>