TileLayer: max_native_zoom cannot be null #2044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2043.
In #2029 we changed the way we parse options. Before, in
parse_options
, None values would be discarded. In thetojavascript
filter this doesn't happen. This leads to different outcomes, and issues like some tile layers not rendering.I first looked at removing all None values like before, but that seems heavy handed and might lead to other issues. Instead, do a targeted fix that just makes sure
max_native_zoom
always has an integer value. If it's not available, we can set it to max_zoom, which has the same effect as not including it at all.