Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed file #2030

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Add py.typed file #2030

merged 1 commit into from
Nov 17, 2024

Conversation

hamdanal
Copy link
Contributor

Follow up to #1677
Closes #1559

This tells type checkers like mypy that this package contains type hints so that other projects can type check their code that imports folium. See https://mypy.readthedocs.io/en/stable/installed_packages.html#creating-pep-561-compatible-packages

Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamdanal! Kinda dumb we missed this, but I'm happy you added it after all!

@Conengmo Conengmo merged commit 2a2da39 into python-visualization:main Nov 17, 2024
11 checks passed
@hamdanal hamdanal deleted the py.typed branch November 17, 2024 16:08
@hamdanal
Copy link
Contributor Author

Thanks @hamdanal! Kinda dumb we missed this, but I'm happy you added it after all!

Thank you. I’m sure you are not the first to forget it — it is unfortunate that mypy doesn’t warn when the file is missing.

I just realized that branca also has type hints but is missing the py.typed file. I’ll open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support type hinting
2 participants