Stop using ctypes for traceback mutation #3203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 124 124
Lines 18792 18760 -32
Branches 1268 1267 -1
===============================================
- Hits 18792 18760 -32
|
CoolCat467
requested changes
Feb 9, 2025
| "TracebackType", | ||
| tputil.make_proxy(controller, type(base_tb), base_tb), | ||
| ) # Returns proxy to traceback | ||
|
|
||
|
|
||
| # this is used for collapsing single-exception ExceptionGroups when using | ||
| # `strict_exception_groups=False`. Once that is retired this function and its helper can |
There was a problem hiding this comment.
"and its helper" does not apply anymore with removing this
Comment on lines
5
to
8
| ################################################################ | ||
| # concat_tb | ||
| ################################################################ | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
It's kind of unnecessary since we'll rip this code out anyways once strict exception groups are the only thing supported, but for now it's simpler.