Remove src/poetry/__init__.py to convert to namespace package

[lafrenierejm]

Pull Request Check List

Resolves: #3735

• Added tests for changed code. (Not applicable)
• Updated documentation for changed code. (Not applicable)

The corresponding change was made in python-poetry/poetry-core@fa93845.

[lafrenierejm]

Any ideas why pre-commit is failing?

[dimbleby]

pre-commit is failing because it explicitly bans implicit-namespace-packages:

poetry/.pre-commit-config.yaml

Line 39 in f33c9db

- flake8-no-pep420==1.2.0

.

If this MR goes ahead you'll also need to fix things that are broken by implicit namespaces. mypy for instance, I think you'd want to set all of namespace_packages, explicit_package_bases, mypy_path - all as in poetry-core.

However, since poetry-core has already done this - python-poetry/poetry-core#251 - there is already no collision of __init__.py. So perhaps #3735 can simply be closed without further action?

[lafrenierejm]

If this MR goes ahead you'll also need to fix things that are broken by implicit namespaces. mypy for instance, I think you'd want to set all of namespace_packages, explicit_package_bases, mypy_path - all as in poetry-core.

Thanks for the tip. I have resolved the errors that CI was raising. This PR should now be mergeable if the maintainers so choose.

However, since poetry-core has already done this - python-poetry/poetry-core#251 - there is already no collision of __init__.py. So perhaps #3735 can simply be closed without further action?

AFAIK you are correct that there's no longer any technical reason this PR would be required. My personal preference would still be go ahead and make this package a proper PEP420 namespace package. If a third package is ever added to the poetry namespace, these same errors would arise again.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.