fix: Don't try to parse Links as Paths
#4532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Link`s and `Path`s were passed in to `pip_install` as a string. This makes it hard for pip_install to parse out the extension of the file to install. By accepting only `Link`s or `Path`s, `pip_install` can parse out the extension using the `Link`.
2 tasks
|
Superseded by #4531 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Links andPaths were passed in topip_installas astring. This makes it hard for pip_install to parse out the extension of
the file to install. By accepting only
Links orPaths,pip_installcan parse out the extension using the
Link.This also resolves a bug when
Executor._download_linkis in use and returns aLink, which can't be parsed byPath(str(link))on Windows.This was overlooked when running on Linux because
file:/path/to/cacheis somehow a validpip installpath in Python on Linux, but not a valid path on Windows. With this PR,pip installis always called with a properPath(/path/to/cache) and never aPath-parsedLink(file:/path/to/cache)Not a bug in 1.1.
Pull Request Check List
Resolves: #issue-number-here