Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes to the get-poetry.py file to master #2426

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

sdispater
Copy link
Member

Pull Request Check List

Backport of #1878 to master

  • Added tests for changed code.
  • Updated documentation for changed code.

* get-poetry.py fallback to standard executables

* documentation update

* fix typo due to cleanup

* favor python3 over python2 when creating launcher

* launcher favors 3.5 and up, else the first valid one it finds.

* favor any py3 over py2, not just 3.5+

Co-authored-by: Jonathan Piché <[email protected]>
@sdispater sdispater requested a review from a team May 15, 2020 15:25
@sdispater sdispater merged commit f812822 into master Jun 10, 2020
@sdispater sdispater deleted the backport-get-poetry-changes branch June 10, 2020 07:59
sdispater added a commit that referenced this pull request Jun 11, 2020
sdispater added a commit that referenced this pull request Jun 11, 2020
…try-script

Revert "get-poetry.py fallback to standard executables (#1878) (#2426)"
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants