-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is a quick fix to avoid polluting stdout unexpectedly when Poetry's environment management comes into play. It's apparent from how much the complexity of this file has grown that this needs to be refactored moderately, as well as each major class deserving its own source file. Future work should also include a rethink of how IO objects are passed around the codebase, how we reason about verbosity at a function level, and how code is re-used -- one command may wish to output to stdout, but if that code is reused by another command, the calculus of what is command output and what is informative (or even needs to be hidden/shown based on verbosity level) changes. Work on output would likely have to be fairly comprehensive and invasive, but things have grown complex enough that a top-down design pass is likely the best route. Regardless, this is a simple change today, and low risk. Resolves #6427.
- Loading branch information
1 parent
b9ed1f0
commit 47255c4
Showing
2 changed files
with
25 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters