Merge pull request #201 from python-poetry/fix-caret-zero-parsing

Fix parsing of caret constraint with leading zero
python-poetry · Sep 15, 2021 · 37deae6 · 37deae6
2 parents 14b41a9 + 864f7c6
commit 37deae6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/poetry/core/semver/version.py b/poetry/core/semver/version.py
@@ -37,7 +37,7 @@ def stable(self) -> "Version":
 
     def next_breaking(self) -> "Version":
         if self.major == 0:
-            if self.minor != 0:
+            if self.minor is not None and self.minor != 0:
                 return self.next_minor()
 
             if self.precision == 1:

diff --git a/tests/semver/test_helpers.py b/tests/semver/test_helpers.py
@@ -191,7 +191,7 @@ def test_parse_constraint_tilde(input, constraint):
                 Version.from_parts(1, 0, 0), Version.from_parts(2, 0, 0), True
             ),
         ),
-        ("^0", VersionRange(Version.from_parts(0), Version.from_parts(0, 1), True)),
+        ("^0", VersionRange(Version.from_parts(0), Version.from_parts(1), True)),
         (
             "^0.0",
             VersionRange(

diff --git a/tests/semver/test_parse_constraint.py b/tests/semver/test_parse_constraint.py
@@ -188,6 +188,22 @@
                 include_min=True,
             ),
         ),
+        (
+            "^0",
+            VersionRange(
+                min=Version.from_parts(0),
+                max=Version.from_parts(1),
+                include_min=True,
+            ),
+        ),
+        (
+            "^0.0",
+            VersionRange(
+                min=Version.from_parts(0, 0),
+                max=Version.from_parts(0, 1),
+                include_min=True,
+            ),
+        ),
     ],
 )
 def test_parse_constraint(constraint, version):