Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yapf formatting fails when pyproject.toml is in the workspace #260

Closed
masad-frost opened this issue Sep 1, 2022 · 1 comment · Fixed by #346
Closed

yapf formatting fails when pyproject.toml is in the workspace #260

masad-frost opened this issue Sep 1, 2022 · 1 comment · Fixed by #346
Milestone
v1.7.2

Comments

@masad-frost
Copy link
Contributor

masad-frost commented Sep 1, 2022 •
edited
Loading

Version: 1.5.0

Steps to reproduce:

  • Create workspace with pyproject.toml
  • Install pylsp with yapf
  • send a format request (must include options)
  • error formatting error: toml package is needed for using pyproject.toml as a configuration file

I think I introduced this regression in #134.

Should we add toml as a requirement for yapf formatter like whatthepatch?
@ccordoba12
Copy link
Member

Sure, I see no problem with that.

@SFrijters SFrijters mentioned this issue Nov 21, 2022
Closed
13 tasks
SFrijters added a commit to SFrijters/nixpkgs that referenced this issue Nov 22, 2022
@SFrijters
python3Packages.python-lsp-server: Add undeclared but necessary optio…
608724d 
…nal dependency

This is no longer implicitly provided by python3Packages.autopep8, causing tests to fail.
Upstream issue: python-lsp/python-lsp-server#260
bjornfor pushed a commit to NixOS/nixpkgs that referenced this issue Nov 23, 2022
@SFrijters @bjornfor
python3Packages.python-lsp-server: Add undeclared but necessary optio…
67a1a34 
…nal dependency

This is no longer implicitly provided by python3Packages.autopep8, causing tests to fail.
Upstream issue: python-lsp/python-lsp-server#260
github-actions bot pushed a commit to NixOS/nixpkgs that referenced this issue Nov 23, 2022
@SFrijters @github-actions
python3Packages.python-lsp-server: Add undeclared but necessary optio…
cec2383 
…nal dependency

This is no longer implicitly provided by python3Packages.autopep8, causing tests to fail.
Upstream issue: python-lsp/python-lsp-server#260

(cherry picked from commit 608724d)
bjornfor pushed a commit to NixOS/nixpkgs that referenced this issue Nov 23, 2022
@SFrijters @bjornfor
python3Packages.python-lsp-server: Add undeclared but necessary optio…
990039e 
…nal dependency

This is no longer implicitly provided by python3Packages.autopep8, causing tests to fail.
Upstream issue: python-lsp/python-lsp-server#260

(cherry picked from commit 608724d)
This was referenced Jan 25, 2023
Merged
Merged
@ccordoba12 ccordoba12 added this to the v1.7.2 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging a pull request may close this issue.

Add toml dependency for yapf and constrain yapf to be less than 0.32 bnavigator/python-lsp-server
2 participants
@ccordoba12 @masad-frost