Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions #410

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update GitHub Actions #410

merged 1 commit into from
Sep 4, 2024

Conversation

vstinner
Copy link
Contributor

@vstinner vstinner commented Jun 5, 2024 •
edited
Loading

  • Don't test old Python on macos-latest. GitHub Action macos-latest was updated to arm64 which only supports recent Python versions. Continue testing old Python versions on Ubuntu.
  • Fix make-manylinux: set /greenlet as safe directory.

@vstinner vstinner marked this pull request as ready for review June 5, 2024 10:28
@vstinner vstinner mentioned this pull request Jun 5, 2024
Merged
@vstinner
Copy link
Contributor Author

vstinner commented Jun 5, 2024 •
edited
Loading

tests / musllinux_1_1_x86_64 and tests / musllinux_1_1_aarch64 fail with: Could not read from remote repository. Example:

Status: Downloaded newer image for quay.io/pypa/musllinux_1_1_x86_64:latest
Cloning into 'greenlet'...
fatal: detected dubious ownership in repository at '/greenlet/.git'
To add an exception for this directory, call:

	git config --global --add safe.directory /greenlet/.git
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Error: Process completed with exit code 128.

Should we disable these two jobs for now?

cc @jamadden

@vstinner vstinner marked this pull request as draft June 5, 2024 11:04
@vstinner
Update GitHub Actions
45a8e6e 
* Don't test old Python on macos-latest. GitHub Action macos-latest
  was updated to arm64 which only supports recent Python versions.
  Continue testing old Python versions on Ubuntu.
* Fix make-manylinux: set /greenlet as safe directory
@vstinner vstinner changed the title Don't test old Python on macos-latest Update GitHub Actions Jun 5, 2024
@vstinner vstinner marked this pull request as ready for review June 5, 2024 11:18
@vstinner
Copy link
Contributor Author

vstinner commented Jun 5, 2024

@jamadden: Ok, here is a PR to repair greenlet CI.

@vstinner
Copy link
Contributor Author

@jamadden: I spent a few weeks to port greenlet to Python 3.13: #396 Sadly, the PR is blocked the outdated CIs. So I wrote this PR to update CI to make them pass. Would you mind to review this PR?

@vstinner
Copy link
Contributor Author

@jamadden: Gentle ping. How can I help you to repair the greenlet CI?

@4383
Copy link

4383 commented Jul 4, 2024

@jamadden: Hey Jason, please could you have a look to this patch? It would unlock many PR. Thank you for your time.

cclauss
cclauss reviewed Aug 13, 2024
View reviewed changes
.github/workflows/tests.yml
Comment on lines +29 to +32
os: [ubuntu-latest]
include:
- os: macos-latest
python: 3.12
Copy link

@cclauss cclauss Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More surgical...

Suggested change
os: [ubuntu-latest]
include:
- os: macos-latest
python: 3.12
os: [ubuntu-latest, macos-latest]
exclude:
- python-version: 3.7
os: macos-latest

@jamadden
Copy link
Contributor

jamadden commented Sep 4, 2024

Thank you very much!

@jamadden jamadden merged commit 96d63ea into python-greenlet:master Sep 4, 2024
17 checks passed
@vstinner vstinner deleted the update_gha branch September 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @4383 @jamadden @cclauss