Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow processing message files that are in locales unknown to Babel #557

Merged
merged 1 commit into from
May 28, 2018

Conversation

akx
Copy link
Member

@akx akx commented Feb 2, 2018

⚠️ This slightly changes the API of the Catalog object, so projects doing esoteric things with them (e.g. setting .locale post-fact) may break.

Fixes #553
Fixes #555

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #557 into master will increase coverage by 0.02%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   90.23%   90.26%   +0.02%     
==========================================
  Files          24       24              
  Lines        4045     4067      +22     
==========================================
+ Hits         3650     3671      +21     
- Misses        395      396       +1
Impacted Files Coverage Δ
babel/messages/catalog.py 94.67% <96.87%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3181e8e...c60e26a. Read the comment docs.

@akx akx requested a review from a team February 2, 2018 16:24
@EndenDragon
Copy link

Any updates on this pull request yet?

@akx
Copy link
Member Author

akx commented May 28, 2018

I suppose I'll merge this and we'll see what happens.

@akx akx merged commit 3e8ef19 into master May 28, 2018
@akx akx deleted the messages-no-locale branch May 28, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants