-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BACKPORT: Introduction of Config.invocation_args #6870
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1 @@ | ||||||||||
New ``Config.invocation_args`` attribute containing the unchanged arguments passed to ``pytest.main()``. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add a remark here:
Suggested change
@asottile what do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 makes it much more clear that this is one-off and not a greenlight to resume features on 4.6 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remark added, it makes a lot of sense. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh just noticed this was not added in the end. No worries, I will update directly on #7199. 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I committed it locally and never pushed 🤦. Sorry about that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem 😁 4.6.10 has been released btw! 👍 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,9 @@ are available on PyPI. | |
|
||
While pytest ``5.0`` will be the new mainstream and development version, until **January 2020** | ||
the pytest core team plans to make bug-fix releases of the pytest ``4.6`` series by | ||
back-porting patches to the ``4.6-maintenance`` branch that affect Python 2 users. | ||
back-porting patches to the ``4.6.x`` branch that affect Python 2 users. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since there is not an actual There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need to port to master, we have changed that significantly already: https://docs.pytest.org/en/latest/py27-py34-deprecation.html |
||
|
||
**After 2020**, the core team will no longer actively backport patches, but the ``4.6-maintenance`` | ||
**After 2020**, the core team will no longer actively backport patches, but the ``4.6.x`` | ||
branch will continue to exist so the community itself can contribute patches. The core team will | ||
be happy to accept those patches and make new ``4.6`` releases **until mid-2020**. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this the thing to do when back-porting things. If it's not, let me know! Just following the steps-to-contribute 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is definitely the right thing! 👍