Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for unsupported Python versions #2823

Merged
merged 3 commits into from
Oct 10, 2017
Merged

Remove code for unsupported Python versions #2823

merged 3 commits into from
Oct 10, 2017

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 10, 2017

Follow on from #2822 and for #2812 and removes some other code for old unsupported versions.


Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS;

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work running trough all the small details 👍

@hugovk
Copy link
Member Author

hugovk commented Oct 10, 2017

Marking the news fragment as done, as there's already one in #2822:

remove support for the eol python versions 2.6 and 3.3

(This PR also removes some < (2,6) and < (2,5) :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 92.562% when pulling 7113c76 on hugovk:features-rm-2.6 into dd45f8b on pytest-dev:features.

@RonnyPfannschmidt
Copy link
Member

well done, its really nice to have someone step in and sort out all the little tedious details 👍

@RonnyPfannschmidt RonnyPfannschmidt merged commit 1480aed into pytest-dev:features Oct 10, 2017
@hugovk hugovk deleted the features-rm-2.6 branch October 10, 2017 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants