Improve reporting from __iter__ exceptions #11308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaganjlee
force-pushed
the
iter-reporting
branch
from
1ae5e73 to
c0cf822
Compare
Zac-HD
reviewed
Aug 20, 2023
src/_pytest/assertion/util.py
Outdated
Comment on lines
135
to
138
| except TypeError: | ||
| return False | ||
| except Exception as e: | ||
| raise ValueError( |
There was a problem hiding this comment.
I think we should probably just replace except TypeError: with except Exception: here - if calling iter(obj) raises an error, it seems reasonable to treat that as "not iterable" rather than a special error case.
There was a problem hiding this comment.
Hm I think the error message is helpful if people don't expect it, but I can see that this adds to things to maintain
Zac-HD
approved these changes
Aug 21, 2023
|
Thanks Reagan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7966
Previously, the assertion rewrite mechanism would fail to capture raised errors within
__iter__and suggest the error is within__repr__, which this new reporting now fixes.