Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to the Where to patch docs in monkeypatch.setattr #10217

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

nicoddemus
Copy link
Member

This should help users with the common issue of patching the wrong place.

Also took the opportunity of using proper links in the monkeypatch introduction.

Related to #10216

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 15, 2022
@nicoddemus nicoddemus force-pushed the monkeypatch-docs-10216 branch from 09f1673 to 43c2a54 Compare August 15, 2022 13:39
This should help users with the common issue of patching the wrong place.

Also took the opportunity of using proper links in the monkeypatch introduction.

Related to pytest-dev#10216
@nicoddemus nicoddemus force-pushed the monkeypatch-docs-10216 branch from 43c2a54 to d1d8c03 Compare August 15, 2022 13:42
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. I left a small suggestion.

src/_pytest/monkeypatch.py Outdated Show resolved Hide resolved
@nicoddemus nicoddemus enabled auto-merge (squash) August 15, 2022 16:48
@nicoddemus nicoddemus disabled auto-merge August 15, 2022 16:54
@nicoddemus nicoddemus merged commit 2e7c718 into pytest-dev:main Aug 15, 2022
@nicoddemus nicoddemus deleted the monkeypatch-docs-10216 branch August 15, 2022 16:55
@nicoddemus nicoddemus added backport 7.1.x and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants