Do not change PYTHONPATH or sys.path on workers #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
do-not-change-pythonpath
branch
from
09703cb to
94a35b2
Compare
| channel = channel # noqa | ||
| workerinput, args, option_dict = channel.receive() | ||
| importpath = os.getcwd() | ||
| sys.path.insert(0, importpath) # XXX only for remote situations | ||
| os.environ["PYTHONPATH"] = ( |
There was a problem hiding this comment.
only after archeology ^^
There was a problem hiding this comment.
Fair enough.
The only archaeology I could find is this one: #376 (comment)
There was a problem hiding this comment.
based on this not having it breaks remote workers, and tox is completely unusable to feed those as tox never got that part done
RonnyPfannschmidt
requested changes
Jan 8, 2019
nicoddemus
force-pushed
the
do-not-change-pythonpath
branch
from
94a35b2 to
f8d51aa
Compare
RonnyPfannschmidt
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #396
Fix #376