feat: Added forced visual capture script #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #95 +/- ##
========================================
Coverage 62.63% 62.63%
========================================
Files 5 5
Lines 182 182
========================================
Hits 114 114
Misses 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Quick question: why did you add the label "invalid" ? 😅 |
|
Hi @frgfm, the current capture method was "invalid". But maybe I'm not using the tag properly |
|
capture method? what are we talking about? the camera? the tag "invalid" is usually used on "invalid" issues for instance 😅 (meaning that the raised concern / issue is irrelevant or non applicable) |
frgfm
added
ext: src
type: new feature
and removed
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline we need a function to capture an image from each camera mainly for debugging purposes. However it is dangerous to do what was done in the PR #92 we don't want to interfere with the runner. This PR proposes to remove the modification from the previous PR and create an independent script