Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve logging of Engine #94

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

MateoLostanlen
Copy link
Member

Small PR to have two different messages in case of detection or not

@MateoLostanlen MateoLostanlen added the type: enhancement New feature or request label Jul 24, 2022
@MateoLostanlen MateoLostanlen requested review from a team July 24, 2022 16:16
@MateoLostanlen MateoLostanlen self-assigned this Jul 24, 2022
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #94 (006fe8b) into develop (570e2e2) will decrease coverage by 1.04%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop      #94      +/-   ##
===========================================
- Coverage    63.68%   62.63%   -1.05%     
===========================================
  Files            5        5              
  Lines          179      182       +3     
===========================================
  Hits           114      114              
- Misses          65       68       +3     
Flag Coverage Δ
unittests 62.63% <25.00%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyroengine/engine/engine.py 51.85% <25.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@MateoLostanlen MateoLostanlen merged commit ef6348e into pyronear:develop Jul 24, 2022
@MateoLostanlen MateoLostanlen deleted the feature/logs branch July 24, 2022 17:21
@frgfm frgfm added this to the 0.2.0 milestone Aug 7, 2022
@frgfm frgfm changed the title improve logs feat: Improve logging of Engine Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants