Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Disabled urllib warnings #93

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

MateoLostanlen
Copy link
Member

I did not really understand why but the request with the url in http bugs sometimes which is not the case in https

@MateoLostanlen MateoLostanlen added the type: bug Something isn't working label Jul 24, 2022
@MateoLostanlen MateoLostanlen requested review from a team July 24, 2022 15:51
@MateoLostanlen MateoLostanlen self-assigned this Jul 24, 2022
@MateoLostanlen
Copy link
Member Author

I'm resetting a new pi-runner so it's not working right now

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #93 (722b1d9) into develop (245cd1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #93   +/-   ##
========================================
  Coverage    63.68%   63.68%           
========================================
  Files            5        5           
  Lines          179      179           
========================================
  Hits           114      114           
  Misses          65       65           
Flag Coverage Δ
unittests 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@MateoLostanlen MateoLostanlen merged commit 570e2e2 into pyronear:develop Jul 24, 2022
@MateoLostanlen MateoLostanlen deleted the bugfix/get_image branch July 24, 2022 17:21
@frgfm frgfm added type: enhancement New feature or request ext: src and removed type: bug Something isn't working labels Aug 7, 2022
@frgfm frgfm added this to the 0.2.0 milestone Aug 7, 2022
@frgfm frgfm changed the title Bugfix/get image refactor: Disabled urllib warnings Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: src type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants