Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prefix to bucket name #382

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Add a prefix to bucket name #382

merged 3 commits into from
Dec 18, 2024

Conversation

RonanMorgan
Copy link
Collaborator

Currently we have a conflict between bucket name because in our OVH account we have many environment (production + dev *2). This small refactor prevent this conflicts

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (40cda4a) to head (3a5ebb7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files          35       35           
  Lines         996      996           
=======================================
  Hits          845      845           
  Misses        151      151           
Flag Coverage Δ
backend 84.35% <100.00%> (ø)
client 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agree with the fix, but for the sake of limiting the number of env vars, I think we should mutualize this with SERVER_NAME and probably renaming it to INSTANCE_NAME (or by default using socket.gethostname() or something unique to the VM so that we don't have to figure out which prefix isn't being used)

@frgfm frgfm added the type: fix Something isn't working label Nov 1, 2024
@RonanMorgan
Copy link
Collaborator Author

RonanMorgan commented Nov 4, 2024

ok ! I just merged with main and pushed the modification

@RonanMorgan RonanMorgan requested a review from frgfm November 4, 2024 09:48
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Only one thing to consider: the s3 bucket initialization might be conflicting with this new rule https://github.com/pyronear/pyro-api/blob/main/scripts/localstack/setup-s3.sh

Make sure to test it out before merging 🙏

@RonanMorgan RonanMorgan merged commit 7a0dcd7 into main Dec 18, 2024
29 checks passed
@RonanMorgan RonanMorgan deleted the rs/add-s3-prefix branch December 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants