Respect thresholds in scaled months #365
Conversation
| @@ -46,21 +46,23 @@ month: | |||
| ``` | |||
|
|
|||
| ### Colored by Values | |||
| Use parameter `circleColorByValue`, color the circles based on the values | |||
| Use parameters `circleColorByValue`, `yMin`, and `yMax`, to color the circles based on the values | |||
There was a problem hiding this comment.
I think it's worth emphasizing that you need to set all 3 of these in order for it to take effect.
| @@ -6,7 +6,7 @@ bloodpressure: 177/119 | |||
|
|
|||
| #weight:70.0kg | |||
|
|
|||
| #exercise-pushup:35 | |||
| #exercise-pushup:5 | |||
There was a problem hiding this comment.
This date should now have no circle, because it is beneath the threshold.
There was a problem hiding this comment.
I see it circled when I test your branch locally
There was a problem hiding this comment.
The issue is that you have to update all of the 2021-01-05 files to handle for all the various date formats. When I update 2021-01-05.md, the test works
|
@pyrochlore FYI. I'd be interested to hear your thoughts on this / the underlying issue. P.S. thank you for the awesome project! Both very neat and useful! |
| @@ -6,7 +6,7 @@ bloodpressure: 177/119 | |||
|
|
|||
| #weight:70.0kg | |||
|
|
|||
| #exercise-pushup:35 | |||
| #exercise-pushup:5 | |||
There was a problem hiding this comment.
I see it circled when I test your branch locally
|
I applied the missing fixes. Thanks for your contribution |
|
@lazyguru TY so much! |
Description
See #364 for description. Ensures that the
monthgraph'sthresholdparameter, even whencircleColorByValueis also used.Fixes #364
Note that I just raised that issue myself, and it appears that the behavior I'm removing was added intentionally. So, I'd understand if this PR is rejected (although I would be curious to hear why it behaves the way it does).
Type of change
Please delete options that are not relevant.
How Has This Been Tested?