Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Stacked Bar Chart #enhancement #351

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

xychang
Copy link
Contributor

@xychang xychang commented Apr 28, 2024

Description

Enable stacked bar chart when user set stack to true.
Currently only works with all positive or all negative numbers.

Screenshot 2024-04-27 220239

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • If this is a bug fix, did you add or update a test file to the examples directory that verifies the bug is fixed?
  • If this is a new feature, did you add files to the examples directory to demonstrate the feature?
  • If this is a new feature, did you add documentation to the docs directory for the feature?

@@ -905,16 +917,23 @@ function renderBar(
// console.log(dataset);
// console.log(barInfo);
// console.log("%d/%d", currBarSet, totalNumOfBarSets);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick and I'll fix this after the merge, but please try to avoid adding whitespace like this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

@lazyguru lazyguru merged commit 9ae9084 into pyrochlore:master Apr 29, 2024
@lazyguru
Copy link
Collaborator

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants