Change streak counts to terminate on falsey values rather than null #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right before preparing this PR, I just noticed that @lazyguru responded to a previous message I made in #291 ensuring me that he would work on this instead. But by then I already wrote this up, so sorry if I either made @lazyguru or myself do unnecessary work. I will figure out how to turn on emails for git threads in the future. |
|
No worries. I only began investigating. Will review your PR today |
lazyguru
approved these changes
Jan 19, 2024
| @@ -167,7 +167,7 @@ const fnMapDatasetToValue: FnMapDatasetToValue = { | |||
| let streak = 0; | |||
| let maxStreak = 0; | |||
| for (let dataPoint of dataset) { | |||
| if (dataPoint.value !== null) { | |||
| if (dataPoint.value) { | |||
There was a problem hiding this comment.
And this is why I "love" typescript (sarcasm). dataPoint.value is supposed to be a number field, however in reality Obsidian is passing in booleans as well.
|
Thanks for your contribution. I'll do a release a little later this evening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes some lines in expr.ts to check for any falsey value (or any truthy value) rather than the explicit presence of null. This allows users to define true/false frontmatter tags, with false not counting towards a streak. This is how Obsidian handles checkbox properties, so it fixes issues concerning those too.
Fixes # (issue)
#299 #291
Type of change
How Has This Been Tested?