Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to support displaying all authors on PyPI page? #12877

Open
matthewfeickert opened this issue Jan 20, 2023 · 3 comments
Open

Possible to support displaying all authors on PyPI page? #12877

matthewfeickert opened this issue Jan 20, 2023 · 3 comments
Labels
feature request requires triaging maintainers need to do initial inspection of issue

Comments

@matthewfeickert
Copy link

What's the problem this feature will solve?

👋 Hi. Our project pyhf just switched (c.f. scikit-hep/pyhf#2095) from having our PyPI metadata in setup.cfg to pyproject.toml. In doing so, we also changed from having our author metadata for the 3 authors be across author and author_email to having it be contained in authors following PEP 621's requirements of

These fields accept an array of tables with 2 keys: name and email. Both values must be strings. The name value MUST be a valid email name (i.e. whatever can be put as a name, before an email, in RFC 822) and not contain commas. The email value MUST be a valid email address. Both keys are optional.

pip is recognizing all the metadata as we would expect

$ python -m pip show pyhf
Name: pyhf
Version: 0.7.1.dev43
Summary: pure-Python HistFactory implementation with tensors and autodiff
Home-page: 
Author: 
Author-email: Lukas Heinrich <[email protected]>, Matthew Feickert <[email protected]>, Giordon Stark <[email protected]>
License: Apache-2.0
Location: /home/feickert/.pyenv/versions/3.10.6/envs/pyhf-dev-CPU/lib/python3.10/site-packages
Requires: click, jsonpatch, jsonschema, numpy, pyyaml, scipy, tqdm
Required-by:

However, when we published this to TestPyPI to check how things looked after switching over we noticed that TestPyPI is displaying only the first author and linking their email

testPyPI

Previously when we shoved all our names and emails into author and author_email we could at least have all our names be displayed (no surprise there as we were abusing the field)

PyPI-0 7 0

I assume that this behavior with authors is because warehouse uses only the core metadata here (?) following PEP 621's instructions of:

Using the data to fill in core metadata is as follows:

  1. If only name is provided, the value goes in Author/Maintainer as appropriate.
  2. If only email is provided, the value goes in Author-email/Maintainer-email as appropriate.
  3. If both email and name are provided, the value goes in Author-email/Maintainer-email as appropriate, with the format {name} <{email}> (with appropriate quoting, e.g. using email.headerregistry.Address).
  4. Multiple values should be separated by commas.

Would it be possible for warehouse to display all authors information if it exists? Or is that something that is outside the scope of how warehouse interacts with metadata?

Describe the solution you'd like

Have warehouse be able to parse the existence of PEP 621 authors and display all names and associated emails of authors on the package webpage.

Additional context

@matthewfeickert matthewfeickert added feature request requires triaging maintainers need to do initial inspection of issue labels Jan 20, 2023
@di
Copy link
Member

di commented Jan 20, 2023

Is this a duplicate of #9400?

@matthewfeickert
Copy link
Author

Is this a duplicate of #9400?

Hm I think so. I'll assume yes and close here in favor of it, but actually check when I'm out of my next meeting.

Apologies for the noise: I searched "authors" in the Issues and so missed this as I didn't check all the ones just matching "author".

@di
Copy link
Member

di commented Jan 15, 2025

Reopening because this is distinct from #9400 per #9400 (comment).

@di di reopened this Jan 15, 2025
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 15, 2025
-Create pypi publishing CI workflow based on release tags
-Remove poetry dependencies and some changes like the release version and python versions.
-Add necessary dependency "setuptools-scm" to release.yml to include REPORT.md
-Change version name to 0.2.0.0, read # TODO
-Set absolute links for PyPI Website navigation after publishing a new release
-Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 15, 2025
-Create pypi publishing CI workflow based on release tags
-Remove poetry dependencies and some changes like the release version and python versions.
-Add necessary dependency "setuptools-scm" to release.yml to include REPORT.md
-Change version name to 0.2.0.0, read # TODO
-Set absolute links for PyPI Website navigation after publishing a new release
-Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 15, 2025
-Create pypi publishing CI workflow based on release tags
-Remove poetry dependencies and some changes like the release version and python versions.
-Add necessary dependency "setuptools-scm" to release.yml to include REPORT.md
-Change version name to 0.2.0.0, read # TODO
-Set absolute links for PyPI Website navigation after publishing a new release
-Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 16, 2025
- Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
- add changelog: false to not update CHANGELOG.md in the CI process
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 16, 2025
- Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
- add changelog: false to not update CHANGELOG.md in the CI process
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 16, 2025
-Automate release process completely taking advantage of semantic commits and already-created in GitHub actions
- update version to publish
- Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
- add changelog: false to not update CHANGELOG.md in the CI process
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 17, 2025
-Automate release process completely taking advantage of semantic commits and already-created in GitHub actions
- update version to publish
- Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
- add changelog: false to not update CHANGELOG.md in the CI process
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 20, 2025
-Automate release process completely taking advantage of semantic commits and already-created in GitHub actions
- update version to publish
- Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
- add changelog: false to not update CHANGELOG.md in the CI process
rsanchez87 added a commit to fluendo/fluster that referenced this issue Jan 20, 2025
-Automate release process completely taking advantage of semantic commits and already-created in GitHub actions
- update version to publish
- Change order authors and maintainers to view only one in PyPi web page (Open request here pypi/warehouse#12877)
- add changelog: false to not update CHANGELOG.md in the CI process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request requires triaging maintainers need to do initial inspection of issue
Projects
None yet
Development

No branches or pull requests

2 participants