-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding python-config script to virtualenv bin dir #783
Conversation
Should solve most of pypa#169
Should solve most of pypa#169
I can confirm that this patch fixes issues building Valloric/ycmd |
It seems you've forgotten to add/commit the file |
Hello Matt, |
@madprog the source for all such files needs to live in virtualenv_embedded. They should then be automatically included into |
File was missing, as commented Ivoz (Matt Iversen) References pypa#169
Here is the commit with the missing file. |
@madprog now I can see the contents of the file. It seems to me likely you copied this from a python 2 source. It uses the python 2 only print statement, so this is unsuitable to merge at the moment. Additionally, it doesn't cover the additional options available in a python3 |
BTW make it compatible with python2 and python3 as much as possible
@Ivoz Indeed it was at first copied from a python2-config. At that time (end of 2011), python3 was not that mainstream ;) #!/usr/bin/zsh
for i in prefix exec-prefix includes libs cflags ldflags extension-suffix help abiflags configdir; do
echo "\x1b[32m$i\x1b[0m"
PYTHON2_CMD="diff -u <(python2-config --$i 2>&1) <(python2 python-config --$i 2>&1)"
PYTHON3_CMD="diff -u <(python3-config --$i 2>&1) <(python3 python-config --$i 2>&1)"
if ! $SHELL -c "$PYTHON2_CMD" >/dev/null; then
echo "\x1b[31mpython2\x1b[0m"
$SHELL -c "$PYTHON2_CMD"
fi
if ! $SHELL -c "$PYTHON3_CMD" >/dev/null; then
echo "\x1b[31mpython3\x1b[0m"
$SHELL -c "$PYTHON3_CMD"
fi
done They are not exactly the same on my system: the order of the cflags or libflags is different (but similar), some may be duplicated, and the new options are supported for python2 (except |
Should solve most of #169