Makes --python command-line flag take precedence over env var #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiplajszczak
force-pushed
the
cli-precedence-2285
branch
2 times, most recently
from
bd8ff19 to
606632a
Compare
filiplajszczak
force-pushed
the
cli-precedence-2285
branch
from
fba96f1 to
12a12ab
Compare
gaborbernat
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes #2285
The problem is caused by the current handling of environment variables, which replaces the default value of an action (an empty list) with a list containing the value of the environment variable. The
argparsemodule's"append"action adds to the list rather than overriding it.The fix ensures the environment variable value becomes the last element. Since default discovery uses the first valid interpreter in the
python_speclist, placing the environment variable last allows--pythonto take precedence.This solution is not ideal. A proper fix would require a complete rewrite of environment variable handling. The current implementation in
config/cli/parser.pyappears to be based on incorrect assumptions about the"append"action. This PR offers a reasonable compromise between resolving the issue and avoiding a large refactor.