Better error message when build dependencies not satisfied #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
commented
Feb 14, 2020
| ] | ||
| build-backend = 'setuptools.build_meta' | ||
|
|
||
| [tool.setuptools_scm] |
There was a problem hiding this comment.
Sadly using the toml config degrades really bad on old platforms, so we've dropped it's usage in line with https://github.com/pypa/setuptools_scm#setuppy-usage
ssbarnea
reviewed
Feb 14, 2020
docs/changelog/1621.feature.rst
Outdated
| @@ -0,0 +1,2 @@ | |||
| Fail with better error message if trying to install source with unsupported ``setuptools``, allow ``setuptools-scm >= 2`` | |||
| and move to legacy ``setuptools-scm`` format to support better older platforms (``CentOs`` and such) - by :user:`gaborbernat`. | |||
There was a problem hiding this comment.
Correct it to CentOS 7 (case), the 8 is in much better shape.
This only manifests on old platforms, but as we still support them makes sense to provide better error messages, and relax a bit our build requirements. Signed-off-by: Bernat Gabor <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only manifests on old platforms, but as we still support them
makes sense to provide better error messages, and relax a bit our
build requirements.
To validate using the docker build:
Resolves #1621