Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in uploading signatures (again) #137

Closed
sigmavirus24 opened this issue Oct 1, 2015 · 0 comments
Closed

Bug in uploading signatures (again) #137

sigmavirus24 opened this issue Oct 1, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@sigmavirus24
Copy link
Member

This time the bug originates from a-tal@13c8323 and the refactor.

Because that flattens all values that are sequences, it happens to flatten the gpg_signature field. That causes two parts to be for the gpg_signature which in turn translates to a list when parsed by PyPI and causes a 500 because PyPI tries to call a string operation on a list.

@sigmavirus24 sigmavirus24 self-assigned this Oct 1, 2015
@sigmavirus24 sigmavirus24 added this to the 1.6.3 milestone Oct 1, 2015
sigmavirus24 added a commit that referenced this issue Oct 1, 2015
The gpg_signature field needs to be passed to MultipartEncoder with a
tuple as the value. This was flattening it causing PyPI to receive two
parts with the same name and parsing them into a list.

The values need to otherwise be flattened because in some cases the
MultipartEncoder cannot handle a sequence value that isn't meant to be a
file-like part (e.g., platform).

Closes #137
sigmavirus24 added a commit to sigmavirus24/twine that referenced this issue Oct 3, 2015
This will ideally prevent pypa#137 from regressing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant