pep425tags: don't append 'm' to ABI tag in Python 3.8 #1822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes changes to the
pep425tags
module following changes made in pip and wheel:pypa/pip#6874
pypa/wheel#303
It fixes the
get_abi_tag()
function, which appended am
flag to the ABI tag on Windows despite this tag no longer existing in Python 3.8. For more info see:https://bugs.python.org/issue36707
https://docs.python.org/dev/whatsnew/3.8.html#build-and-c-api-changes
I'm not actually sure whether this function is used anywhere important; my testing was around building and installing wheels and this change didn't seem to be needed, but it is nonetheless good to ensure that the function does the right thing as long as it is there. As such, I am not sure whether it is critical to get this change into the ensurepip shipped with Python 3.8.