fix #625: add tomli to install_requires again #628
Conversation
|
release pipeline is running, will merge after its up |
| 6.3.1 | ||
| ===== | ||
|
|
||
| * fix #625: restore tomli in install_requires after the regression changes in took it out |
There was a problem hiding this comment.
typo?
| * fix #625: restore tomli in install_requires after the regression changes in took it out | |
| * fix #625: restore tomli in install_requires after the regression changes in taking it out |
| ===== | ||
|
|
||
| * fix #625: restore tomli in install_requires after the regression changes in took it out | ||
| and some users never added it even tho they have pyproject.toml files |
There was a problem hiding this comment.
I don't frequent various Python lists, so I don't understand why I suddenly have to add "tomli" as a dependency in my pyproject.toml...
There was a problem hiding this comment.
wit the change in here you dont, initially one was supposed to use setuptools_scm[toml]
There was a problem hiding this comment.
I'm using setuptools_scm[toml] everywhere here and it's still failing, not sure why.
There was a problem hiding this comment.
(Could be my mistake still somehow, but does show it's tricky to get right)
There was a problem hiding this comment.
I think this is transitive, and black is the package breaking. Why it's triggering this at all and not just using a wheel, I don't know.
There was a problem hiding this comment.
Ah, okay, so the problem was that tomli was required even when not using toml configuration, so that's what was breaking black. (Again, still don't know why this wasn't getting a wheel and skipping this entirely, but that's why)
I suggest that you at least yank the broken |
|
new release is up, old release is yanked |
|
Thank you for your quick fix, this fixed our builds! |
fixes #625