Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calver detection fails on -v prefixes when using non-normalized versions #884

Closed
RonnyPfannschmidt opened this issue Aug 11, 2023 · 1 comment
Closed

calver detection fails on -v prefixes when using non-normalized versions #884

RonnyPfannschmidt opened this issue Aug 11, 2023 · 1 comment
Milestone
8.0.0

Comments

@RonnyPfannschmidt
Copy link
Contributor

RonnyPfannschmidt commented Aug 11, 2023 •
edited
Loading

.../setuptools_scm/version.py:396: UserWarning: <ScmVersion v23.08.08.0 dist=2 node=... dirty=True branch=use-node-date-version-for-calver> does not correspond to a valid versioning date, assuming legacy version

happens when trying to use non-normalized versions for calver
@RonnyPfannschmidt
Copy link
Contributor Author

a workaund is tag_regex = "^(?:[\\w-]+-)?[vV]?(?P<version>\\d+(?:\\.\\d+){0,2}[^\\+]*)(?:\\+.*)?$"

@RonnyPfannschmidt RonnyPfannschmidt added this to the 8.0.0 milestone Sep 11, 2023
RonnyPfannschmidt added a commit that referenced this issue Sep 11, 2023
@RonnyPfannschmidt
Merge pull request #897 from RonnyPfannschmidt/fix-884-calver-v-prefix
08f09e4 
fix #884: handle v prefixes for calver by date
@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@RonnyPfannschmidt