Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools_scm: unpinned "typing_extensions" dependency #723

Closed
emfloyd2 opened this issue Jun 22, 2022 · 1 comment · Fixed by #724
Closed

setuptools_scm: unpinned "typing_extensions" dependency #723

emfloyd2 opened this issue Jun 22, 2022 · 1 comment · Fixed by #724
Labels
bug

Comments

@emfloyd2
Copy link

Howdy.

Shouldn't "typing_extensions" dependency be pinned to ">=4.0.0"? Since symbols such as ParamSpec aren't available in older versions

I just ran into issue on internal project leveraging docker - where the typing_extensions dependency of ">3.7" was already being satisfied with typing-extension v3.7.4.3.

An unpinned setuptools_scm installation (via setup_requires of another package) was getting tripped up because of this.
@RonnyPfannschmidt
Copy link
Contributor

will resolve this by not requiring it at runtime in combination with #722

@RonnyPfannschmidt RonnyPfannschmidt mentioned this issue Jun 22, 2022
Merged
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Jun 22, 2022
@RonnyPfannschmidt
minimize bootstrap - fixes pypa#722 and pypa#723
ce7c2dc 
enable self-bootstrap without typing_extensions and importlib_metadata

they are still install requirements however
hswong3i pushed a commit to alvistack/pypa-setuptools_scm that referenced this issue Jun 22, 2022
@RonnyPfannschmidt @hswong3i
minimize bootstrap - fixes pypa#722 and pypa#723
e4b8d6d 
enable self-bootstrap without typing_extensions and importlib_metadata

they are still install requirements however
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

minimize bootstrap - fixes #722 and #722 RonnyPfannschmidt/setuptools_scm
2 participants
@RonnyPfannschmidt @emfloyd2