-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving users away using pep517 as a CLI tool #91
Comments
|
@matthewfeickert I think this question should belong to the python-build tracker. pep517 is going to get rid of the CLI at some point as it wasn't meant to be an official public API. OTOH since python-build is a wrapper around pep517, it's probably reasonable to have check there too. |
@pradyunsg What is the goal with this old vs. new branch thing? Do you have any idea what the deprecation period is going to be? I was a little surprised that y'all decided to branch instead of revert. I will also note that I personally think that while it's a good idea to start incrementally moving people to I definitely think it should be in the PyPA namespace, but it would be very nice if we could do a much more gradual migration. I'm not even confident that a deprecation warning would be appropriate at this point because while I encourage people to be early adopters, there's a good chance it will leave a bad taste in users' mouths if we start pushing them towards |
I'll note that I do think it's fair to stop improving |
The branch was my idea. I'm OK with reverting the change on master if people prefer. |
To clarify my position a bit, I don't really care what branching and maintenance strategy you use, it just seems that maintaining a branch with a deprecation warning in it tends to indicate that the timeline would be pretty rapid — presumably you aren't going to stop cutting releases from master for an extended period of time. I think that — to the extent that it is possible to do so — at least At the end of the day while I think it's fair to say that no support for this was ever really promised because it was considered "experimental", for better or worse no one else stepped up until now, and giving |
Okay, I'm picking this up and working on this, because sigh of course I have no self-control. |
Thanks Pradyun for helping out with it. |
Quite a bit of work's gone into build and I think it's more mature now as an env builder than pep517 was. Should the deprecation warnings be added? |
This comment has been minimized.
This comment has been minimized.
Sounds fair -- @FFY00 you reckon it's OK to start telling users of |
I think given the last release this is reasonable. |
See pypa/pyproject-hooks#91 Signed-off-by: Filipe Laíns <[email protected]>
See pypa/pyproject-hooks#91 Signed-off-by: Filipe Laíns <[email protected]>
See pypa/pyproject-hooks#91 Signed-off-by: Filipe Laíns <[email protected]>
Shouldn't this page be changed? https://setuptools.readthedocs.io/en/latest/build_meta.html 🤦 |
Yes it should! If you could filing an issue over at https://github.com/pypa/setuptools, that'd be great! ^.^ |
* Improve setup and use PEP517 * Create quick-pep517-test.yml * Update quick-pep517-test.yml * Remove test & fix typo * Create test-use-pypa-build.yml * Update test-use-pypa-build.yml * Move from pep517.build to pypa/build pypa/pyproject-hooks#91 * Update setup.cfg * Update setup.cfg Co-authored-by: Myst <[email protected]>
Thanks to @hexagonrecursion, all the checkboxes except making the release are now checked. :) |
This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91
This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91
This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91
@takluyver Do you reckon you'd have time in the near future to cut a release of this package? |
It will probably be a few days before I get to it, but any pypa committer
should be able to make a release (see RELEASE.rst).
…On Tue, 31 Aug 2021, 11:38 Pradyun Gedam, ***@***.***> wrote:
@takluyver <https://github.com/takluyver> Do you reckon you'd have time
in the near future to cut a release of this package?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQB5PXAEJVOQK3DTCPUI3T7SWJRANCNFSM4RCTEPSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Is |
I think it should be. |
This is the issue for tracking our plans for nudging users to transition away from using pep517 from the CLI. These changes would go into the
inc-pep517.build
branch and not the default branch.pep517.build
is usedpep517.check
is usedOriginally posted by @takluyver in #83 (comment) and edited by @pradyunsg
The text was updated successfully, but these errors were encountered: