Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sorting code #5990

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

daveschaefer
Copy link
Contributor

@daveschaefer daveschaefer commented Oct 20, 2023

For #5964
As suggested in #5965

We don't need to cast to dict first, we can just sort.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

For pypa#5964
As suggested in pypa#5965

We don't need to cast to `dict` first, we can just sort.
@matteius
Copy link
Member

Cool thanks! That sporadic mac os build failure has been cropping for me me too in the CI since pip 23.3 -- a retry of that failure will probably work.

@matteius matteius merged commit 1939102 into pypa:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants