Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to match if the part after @ is a valid ref (reject treating URL parts as refs). #5856

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

matteius
Copy link
Member

@matteius matteius commented Aug 22, 2023

Try fixing the other part of #5849

The issue

Sometimes VCS urls have an @ symbol for netloc auth component, try to differentiate if its a valid ref.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius marked this pull request as ready for review August 22, 2023 16:12
@matteius matteius requested a review from oz123 August 22, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants