Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer usage requests sessions and account for the verify_ssl requirements of each source. #5728

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

matteius
Copy link
Member

Thank you for contributing to Pipenv!

The issue

Fixes #5724

The fix

The improvement to the pep 508 URLs for determining appropriate hash did not consider the verify_ssl requirements. Also, it seemed odd to me that even though pipenv is multi-processing we had a global variable for the requests session state. This made it hard to have different requests (some that verify ssl and some that do not). Since the primary point of re-use of the requests session is in the Resolver, I made a patch there to have a separate requests session per source.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius requested a review from oz123 June 11, 2023 05:37
@oz123 oz123 merged commit 2d52034 into main Jun 11, 2023
@oz123 oz123 deleted the 5724-fix branch June 11, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify_ssl broken in 2023.6.2
2 participants