Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the TOML Spec link to the documentation #3643

Merged
merged 6 commits into from
Mar 27, 2019
Merged

added the TOML Spec link to the documentation #3643

merged 6 commits into from
Mar 27, 2019

Conversation

subwafer
Copy link
Contributor

The issue

#3629

The fix

Added a link to the TOML Spec under General Recommendations & Version Control to clarify how Pipfiles should be written.

@subwafer subwafer mentioned this pull request Mar 23, 2019
Closed
@uranusjr
Copy link
Member

The changes look good to me. Would you mind adding a file at news/3629.doc describing this change?

@uranusjr uranusjr added the PR: awaiting-news The PR related to this issue is missing a news fragment and cannot be merged. label Mar 24, 2019
@frostming
Copy link
Contributor

frostming commented Mar 25, 2019 •
edited
Loading

@NicholasSurmava I'm OK with this PR but a little tweak that news name should be 3629.doc.rst

@subwafer
Copy link
Contributor Author

subwafer commented Mar 25, 2019 •
edited
Loading

@NicholasSurmava I'm OK with this PR but a little tweak that news name should be 3629.doc.rst

I actually named the file as such but left out the .rst extension in the commit message... Slight oops.

@frostming
Copy link
Contributor

@NicholasSurmava I meant doc not docs

@uranusjr uranusjr added PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. and removed PR: awaiting-news The PR related to this issue is missing a news fragment and cannot be merged. labels Mar 26, 2019
uranusjr
uranusjr approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just went ahead and renamed it 🙂

@uranusjr uranusjr added Type: Documentation 📖 This issue relates to documentation of pipenv. PR: reviewed The PR related to this issue has been reviewed. labels Mar 26, 2019
@subwafer
Copy link
Contributor Author

I just went ahead and renamed it

Awesome. Thank you. I missed the typo...

@frostming frostming merged commit 43e9e66 into pypa:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. PR: reviewed The PR related to this issue has been reviewed. Type: Documentation 📖 This issue relates to documentation of pipenv.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subwafer @uranusjr @frostming