fix test that was never run because of name collision

pypa · Oct 22, 2024 · 95ab685 · 95ab685
1 parent 1663b3b
commit 95ab685
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/tests/integration/test_import_requirements.py b/tests/integration/test_import_requirements.py
@@ -72,7 +72,7 @@ def test_auth_with_pw_are_variables_passed_to_pipfile(
     mock_find_package_name_from_directory, pipenv_instance_pypi
 ):
     mock_find_package_name_from_directory.return_value = "myproject"
-    with (pipenv_instance_pypi() as p):
+    with pipenv_instance_pypi() as p:
         p.pipenv("run shell")
         project = Project()
         requirements_file = tempfile.NamedTemporaryFile(mode="w+", delete=False)

diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py
@@ -113,23 +113,23 @@ def test_convert_deps_to_pip_extras_no_version():
             {
                 "FooProject": {
                     "version": "==1.2",
-                    "hash": "sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824",
+                    "hashes": ["sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824"],
                 }
             },
             {
-                "FooProject": "FooProject==1.2 --hash=sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824"
+                "FooProject": "FooProject==1.2  --hash=sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824"
             },
         ),
         (
             {
                 "FooProject": {
                     "version": "==1.2",
                     "extras": ["stuff"],
-                    "hash": "sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824",
+                    "hashes": ["sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824"],
                 }
             },
             {
-                "FooProject": "FooProject[stuff]==1.2 --hash=sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824"
+                "FooProject": "FooProject[stuff]==1.2  --hash=sha256:2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824"
             },
         ),
         (
@@ -141,13 +141,13 @@ def test_convert_deps_to_pip_extras_no_version():
                 }
             },
             {
-                "uvicorn": "git+https://github.com/encode/uvicorn.git@master#egg=uvicorn[standard]"
+                "uvicorn": "uvicorn[standard]@ git+https://github.com/encode/uvicorn.git@master"
             },
         ),
     ],
 )
 def test_convert_deps_to_pip_one_way(deps, expected):
-    assert dependencies.convert_deps_to_pip(deps) == [expected.lower()]
+    assert dependencies.convert_deps_to_pip(deps) == expected
 
 
 @pytest.mark.utils