Fix error reporting on Requires-Python conflicts #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
new-resolver-requires-python-error
branch
2 times, most recently
from
98a11e1 to
37ffc99
Compare
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
uranusjr
force-pushed
the
new-resolver-requires-python-error
branch
from
37ffc99 to
9858332
Compare
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
uranusjr
force-pushed
the
new-resolver-requires-python-error
branch
from
9858332 to
d87abdf
Compare
pradyunsg
approved these changes
Mar 7, 2021
pfmoore
approved these changes
Mar 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9541.
Currently, when resolution fails, the error message only shows a
Requires-Pythonline if there is any in the graph. However, theRequiresPythonRequirementis not necessarily the actual cause to the failure.A check is added to make sure the
RequiresPythonRequirementobjects are actually not satisfying, and only report aRequires-Pythonerror if any is. Some extra logic is also added when there are more than one unsatisfyingRequiresPythonRequirementobjects, to show all of them instead of just the first one.