Handle temp dir cleanup errors gracefully #8655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
windows-remove-error-ignore
branch
2 times, most recently
from
f98fd6d to
d48eadc
Compare
Instead of blowing up in the user's face, gracefully carry on with a warning that the operation failed.
uranusjr
force-pushed
the
windows-remove-error-ignore
branch
from
d48eadc to
61dbe1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7567. Instead of blowing up in the user’s face when a temporary directory fails to clean up, this adds an
onerrorhook tormtreethat logs the failure as a warning, and gracefully carry on.